afchung commented on a change in pull request #3779: URL: https://github.com/apache/hadoop/pull/3779#discussion_r783326070
########## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/scheduler/TestContainerSchedulerOppContainersByResources.java ########## @@ -0,0 +1,260 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.yarn.server.nodemanager.containermanager.scheduler; + +import org.apache.hadoop.fs.UnsupportedFileSystemException; +import org.apache.hadoop.test.GenericTestUtils; +import org.apache.hadoop.thirdparty.com.google.common.collect.ImmutableList; +import org.apache.hadoop.yarn.api.protocolrecords.GetContainerStatusesRequest; +import org.apache.hadoop.yarn.api.protocolrecords.StartContainerRequest; +import org.apache.hadoop.yarn.api.protocolrecords.StartContainersRequest; +import org.apache.hadoop.yarn.api.records.ContainerId; +import org.apache.hadoop.yarn.api.records.ContainerLaunchContext; +import org.apache.hadoop.yarn.api.records.ContainerStatus; +import org.apache.hadoop.yarn.api.records.ContainerSubState; +import org.apache.hadoop.yarn.api.records.ExecutionType; +import org.apache.hadoop.yarn.conf.YarnConfiguration; +import org.apache.hadoop.yarn.server.nodemanager.containermanager.BaseContainerManagerTest; +import org.apache.hadoop.yarn.server.nodemanager.containermanager.BaseContainerSchedulerTest; +import org.apache.hadoop.yarn.server.nodemanager.containermanager.container.ContainerState; +import org.apache.hadoop.yarn.server.utils.BuilderUtils; +import org.junit.Assert; +import org.junit.Test; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashSet; +import java.util.List; +import java.util.Set; +import java.util.concurrent.TimeoutException; + +/** + * Tests the behavior of {@link ContainerScheduler} when the max queue length + * is set to {@literal < 0} such that the NM only queues + * containers if there's enough resources on the node to start + * all queued containers. + */ +public class TestContainerSchedulerOppContainersByResources + extends BaseContainerSchedulerTest { + public TestContainerSchedulerOppContainersByResources() + throws UnsupportedFileSystemException { + } + + @Override + public void setup() throws IOException { + conf.set(YarnConfiguration.NM_OPPORTUNISTIC_CONTAINERS_QUEUE_POLICY, + OpportunisticContainersQueuePolicy.BY_RESOURCES.name()); + super.setup(); + } + + private static boolean isSuccessfulRun(final ContainerStatus containerStatus) { + final org.apache.hadoop.yarn.api.records.ContainerState state = + containerStatus.getState(); + final ContainerSubState subState = containerStatus.getContainerSubState(); + switch (subState) { + case RUNNING: + case COMPLETING: + case DONE: + if (subState == ContainerSubState.DONE) { + return state == + org.apache.hadoop.yarn.api.records.ContainerState.COMPLETE; + } + + return true; + default: + return false; Review comment: This particular function is called in tests, which polls the container state to see if the container is running or in a successful state. The `default` option here is when the container is in a not running or failed state. If the container is not yet running, it is still a valid state for the test (and thus "Not yet implemented", should not be thrown). The polling function may just need to wait for longer. Will add JavaDoc to clarify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
