[
https://issues.apache.org/jira/browse/HADOOP-18082?focusedWorklogId=710337&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-710337
]
ASF GitHub Bot logged work on HADOOP-18082:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jan/22 08:53
Start Date: 18/Jan/22 08:53
Worklog Time Spent: 10m
Work Description: jianghuazhu commented on a change in pull request #3891:
URL: https://github.com/apache/hadoop/pull/3891#discussion_r786530523
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
##########
@@ -3046,6 +3046,8 @@ private void internalQueueCall(Call call, boolean
blocking)
} else {
callQueue.add(call);
}
+
+ LOG.debug("{} has entered the CallQueue and is waiting to be
processed.", call);
Review comment:
Thanks @tomscut for the comment and review.
The detailed log here is this:
`
2022-01-18 16:37:56,653 DEBUG org.apache.hadoop.ipc.Server: Call#75 Retry#0
org.apache.hadoop.hdfs.protocol.ClientProtocol.getFileInfo from
xxxx.xxxx.xxxx.xxxx:port has entered the CallQueue and is waiting to be
processed.
2022-01-18 16:37:56,654 DEBUG org.apache.hadoop.ipc.Server: Call#76 Retry#0
org.apache.hadoop.hdfs.protocol.ClientProtocol.getFileInfo from
xxxx.xxxx.xxxx.xxxx:port has entered the CallQueue and is waiting to be
processed.
`
When the Call is processed by Hanler, the detailed log is as follows:
`
2022-01-18 16:37:59,725 [5178363759] - WARN [IPC Server handler 126 on
8025:Server@494] - Slow RPC : create took 509 milliseconds to process from
client Call#76 Retry#0
org.apache.hadoop.hdfs.protocol.ClientProtocol.getFileInfo from
xxxx.xxxx.xxxx.xxxx:port
`
In my opinion, the Calls recorded in these two places should be consistent.
@tomscut , do you have any good suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 710337)
Time Spent: 50m (was: 40m)
> Add debug log when RPC#Reader gets a Call
> -----------------------------------------
>
> Key: HADOOP-18082
> URL: https://issues.apache.org/jira/browse/HADOOP-18082
> Project: Hadoop Common
> Issue Type: Improvement
> Components: rpc-server
> Affects Versions: 2.9.2
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Now there is an important question. That is, we only know when a Call is
> actually executed by the Handler. By logging, we cannot know when the Call
> came in.
> If I log some information from the moment the Call enters the inside of the
> RPC, it will help us to know more about the Call.
> The records here should be in the form of logs, and the priority of the logs
> should not be too high, debug is the best.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
