[
https://issues.apache.org/jira/browse/HADOOP-18082?focusedWorklogId=712797&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712797
]
ASF GitHub Bot logged work on HADOOP-18082:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/22 11:57
Start Date: 21/Jan/22 11:57
Worklog Time Spent: 10m
Work Description: virajjasani commented on a change in pull request #3891:
URL: https://github.com/apache/hadoop/pull/3891#discussion_r789598239
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
##########
@@ -3046,6 +3046,8 @@ private void internalQueueCall(Call call, boolean
blocking)
} else {
callQueue.add(call);
}
+
+ LOG.debug("{} has entered the CallQueue and is waiting to be
processed.", call);
Review comment:
The change to add a DEBUG log seems good, but how about this line
instead?
`LOG.debug("Call has entered the CallQueue and is waiting to be processed.
Call details: {}", call);`
Usually we tend to read object's string presentation at the end to not mix
up with the log statement, e.g RpcCall's toString() has word "from" and perhaps
it becomes bit difficult to read the whole statement at the first sight, but if
put at the end of the statement, we know that now we are only looking at
RpcCall details:
```
@Override
public String toString() {
return super.toString() + " " + rpcRequest + " from " + connection;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 712797)
Time Spent: 1.5h (was: 1h 20m)
> Add debug log when RPC#Reader gets a Call
> -----------------------------------------
>
> Key: HADOOP-18082
> URL: https://issues.apache.org/jira/browse/HADOOP-18082
> Project: Hadoop Common
> Issue Type: Improvement
> Components: rpc-server
> Affects Versions: 2.9.2
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Now there is an important question. That is, we only know when a Call is
> actually executed by the Handler. By logging, we cannot know when the Call
> came in.
> If I log some information from the moment the Call enters the inside of the
> RPC, it will help us to know more about the Call.
> The records here should be in the form of logs, and the priority of the logs
> should not be too high, debug is the best.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
