mukund-thakur commented on a change in pull request #3916:
URL: https://github.com/apache/hadoop/pull/3916#discussion_r790707192
##########
File path:
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/auditing_architecture.md
##########
@@ -141,8 +152,19 @@ thread.
### class `NoopAuditor`
-This auditor creates spans which perform no auditing.
-It is very efficient and reliable.
+This auditor creates spans which doesn't do anything with the events.
+
+```xml
+<property>
+ <name>fs.s3a.audit.service.classname</name>
+ <value>org.apache.hadoop.fs.s3a.audit.impl.NoopAuditor</value>
+</property>
+```
+
+This is *not* the same as disabling auditing, as it still uses the
`ActiveAuditManagerS3A` class
Review comment:
I think I got it. Just changing the classname will still use
ActiveAuditManagerS3A but stubAuditManager will create NoopAuditManagerS3A
which doesn't have threadlocal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
