steveloughran commented on a change in pull request #3916:
URL: https://github.com/apache/hadoop/pull/3916#discussion_r790729182
##########
File path:
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/auditing_architecture.md
##########
@@ -141,8 +152,19 @@ thread.
### class `NoopAuditor`
-This auditor creates spans which perform no auditing.
-It is very efficient and reliable.
+This auditor creates spans which doesn't do anything with the events.
+
+```xml
+<property>
+ <name>fs.s3a.audit.service.classname</name>
+ <value>org.apache.hadoop.fs.s3a.audit.impl.NoopAuditor</value>
+</property>
+```
+
+This is *not* the same as disabling auditing, as it still uses the
`ActiveAuditManagerS3A` class
Review comment:
there is a NoopAuditor, this is the one you could already enable, which
generated `NoopAuditSpans`
but there was also a stub audit manager, which is the class s3afs created to
handle all the audit integration for that instance. it was used in two places
* mock s3a FS instances in unit tests
* in s3afs initialize so even when the aws sdk was probing s3, the request
processing would find something.
the change now then is to make that no op manager the default everywhere,
with tests to verify this. the parameterisation where will cause a bit of
backport conflict with branches which still have s3guard on, i will address that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
