Neilxzn opened a new pull request #3999:
URL: https://github.com/apache/hadoop/pull/3999


   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   https://issues.apache.org/jira/browse/HDFS-16459
   Router' RBFMetrics was not register  in MetricsSystem. We can't find these 
metrics from PrometheusSink. Maybe we should fix it. 
   
    
   
   After fix it ,  some  RBFMetrics will export like this 
   ```
   # HELP rbf_metrics_current_tokens_count Number of router's current tokens
   # TYPE rbf_metrics_current_tokens_count gauge
   
rbf_metrics_current_tokens_count{processname="Router",context="dfs",hostname="xxxx"}
 2 
   ```
   
   ### How was this patch tested?
   no new test
   
   ### For code changes:
   1. DefaultMetricsSystem.instance().register 
   2. use `@Metric` to export metrics
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to