[
https://issues.apache.org/jira/browse/HADOOP-18138?focusedWorklogId=730644&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-730644
]
ASF GitHub Bot logged work on HADOOP-18138:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/22 05:29
Start Date: 22/Feb/22 05:29
Worklog Time Spent: 10m
Work Description: sunchao commented on pull request #4007:
URL: https://github.com/apache/hadoop/pull/4007#issuecomment-1047439392
I see. Didn't know the context. It's a bit confusing to see the stack trace
like this though:
```
PrivilegedAction [as: <principal> (auth:KERBEROS)][action:
org.apache.hadoop.ipc.Client$Connection$2@65fa2f2d]
java.lang.Exception: null
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1875)
~[hadoop-client-api-3.3.1.jar:?]
at
org.apache.hadoop.ipc.Client$Connection.setupIOstreams(Client.java:838)
~[hadoop-client-api-3.3.1.jar:?]
at org.apache.hadoop.ipc.Client$Connection.access$3800(Client.java:414)
~[hadoop-client-api-3.3.1.jar:?]
at org.apache.hadoop.ipc.Client.getConnection(Client.java:1654)
~[hadoop-client-api-3.3.1.jar:?]
at org.apache.hadoop.ipc.Client.call(Client.java:1479)
~[hadoop-client-api-3.3.1.jar:?]
at org.apache.hadoop.ipc.Client.call(Client.java:1432)
~[hadoop-client-api-3.3.1.jar:?]
at
org.apache.hadoop.ipc.ProtobufRpcEngine2$Invoker.invoke(ProtobufRpcEngine2.java:242)
~[hadoop-client-api-3.3.1.jar:?]
at
org.apache.hadoop.ipc.ProtobufRpcEngine2$Invoker.invoke(ProtobufRpcEngine2.java:129)
~[hadoop-client-api-3.3.1.jar:?]
at com.sun.proxy.$Proxy14.delete(Unknown Source) ~[?:?]
```
and it could makes people think there's something wrong in the `doAs`
method. Maybe we can strip the first line of the stacktrace and replace with
something like:
```
PrivilegedAction [as: <principal> (auth:KERBEROS)][action:
org.apache.hadoop.ipc.Client$Connection$2@65fa2f2d]
Call stacktrace:
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1875)
~[hadoop-client-api-3.3.1.jar:?]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 730644)
Time Spent: 0.5h (was: 20m)
> UserGroupInformation shouldn't log exception
> ---------------------------------------------
>
> Key: HADOOP-18138
> URL: https://issues.apache.org/jira/browse/HADOOP-18138
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In {{UserGroupInformation.doAs}}, we currently create a new {{Exception}} and
> log it in {{LOG.debug}}. This doesn't look necessary:
> {code}
> if (LOG.isDebugEnabled()) {
> LOG.debug("PrivilegedAction [as: {}][action: {}]", this, action,
> new Exception());
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
