[
https://issues.apache.org/jira/browse/HADOOP-18138?focusedWorklogId=731029&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-731029
]
ASF GitHub Bot logged work on HADOOP-18138:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/22 15:40
Start Date: 22/Feb/22 15:40
Worklog Time Spent: 10m
Work Description: busbey edited a comment on pull request #4007:
URL: https://github.com/apache/hadoop/pull/4007#issuecomment-1047924692
I'm wary of things that require us to reimplement the logging system
handling the stack trace details. Maybe we could convey the purpose in either
the exception message or the exception type instead?
e.g.
```java
if (LOG.isDebugEnabled()) {
LOG.debug("PrivilegedAction [as: {}][action: {}]", this, action,
new JustForDebuggingException("call stack for privileged action;
not an indication of a failure"));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 731029)
Time Spent: 50m (was: 40m)
> UserGroupInformation shouldn't log exception
> ---------------------------------------------
>
> Key: HADOOP-18138
> URL: https://issues.apache.org/jira/browse/HADOOP-18138
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In {{UserGroupInformation.doAs}}, we currently create a new {{Exception}} and
> log it in {{LOG.debug}}. This doesn't look necessary:
> {code}
> if (LOG.isDebugEnabled()) {
> LOG.debug("PrivilegedAction [as: {}][action: {}]", this, action,
> new Exception());
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
