Hexiaoqiao commented on a change in pull request #4016:
URL: https://github.com/apache/hadoop/pull/4016#discussion_r812559159
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
##########
@@ -1378,7 +1378,7 @@ public long monotonicNow() {
private final BlockingQueue<Runnable> queue;
CommandProcessingThread(BPServiceActor actor) {
- super("Command processor");
+ setName("Command processor-" + getId());
Review comment:
> Putting the NN address in would not disambiguate the logs because they
would all be for the same NN still. It would give more information, sure, but
not actually helpful information.
Sorry I don't this information. IIUC, now each command processor match to
block pool one by one. and actually `nnAddr` includes hostname/port together. I
mean that it could different each other even for MiniDFSCluster framework.
Right? for another way, with nnAddr, it could be helpful to dig when this
thread meet issues.
Anyway, I don't disagree to add getId() also here. We could add both them to
the thread name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
