ayushtkn commented on a change in pull request #4016:
URL: https://github.com/apache/hadoop/pull/4016#discussion_r812562187
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
##########
@@ -1378,7 +1378,7 @@ public long monotonicNow() {
private final BlockingQueue<Runnable> queue;
CommandProcessingThread(BPServiceActor actor) {
- super("Command processor");
+ setName("Command processor-" + getId());
Review comment:
I think the issue here is in case of MiniDfsCluster all datanodes log at
one place.Means if we spin a MiniDfsCluster with 9 datanodes, all Command
processor threads will log at same place, and we can't distinguish, which
thread belongs to which datanode.
DN1 will also have same name & DN2 till DN9. If we add namenode address,
then also the names of the thread will stay same right? All datanodes in a
single MiniDfs will be connected to same set of namenodes, right?
May be adding DN address should be a good idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
