steveloughran commented on pull request #2971:
URL: https://github.com/apache/hadoop/pull/2971#issuecomment-1060805706
other than those from test numbering, there are now some real style
regressions. also, importing in abfs is a mess as new imports are going in near
the migrated guava imports.
```
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/files/DirEntry.java:135:
if (this == o) {return true;}:20: '{' at column 20 should have line break
after. [LeftCurly]
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/files/DirEntry.java:135:
if (this == o) {return true;}:32: ';' is not followed by whitespace.
[WhitespaceAfter]
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/files/DirEntry.java:136:
if (o == null || getClass() != o.getClass()) {return false;}:50: '{' at
column 50 should have line break after. [LeftCurly]
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/files/DirEntry.java:136:
if (o == null || getClass() != o.getClass()) {return false;}:63: ';' is not
followed by whitespace. [WhitespaceAfter]
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/impl/ManifestCommitterSupport.java:26:import
org.apache.hadoop.classification.InterfaceStability;:8: Unused import -
org.apache.hadoop.classification.InterfaceStability. [UnusedImports]
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/AbstractManifestCommitterTest.java:523:
private List<Future<Path>> createFilesOrDirs(:30: More than 7 parameters
(found 8). [ParameterNumber]
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestCommitTaskStage.java:39:/**:
First sentence should end with a period. [JavadocStyle]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
