steveloughran commented on pull request #2971:
URL: https://github.com/apache/hadoop/pull/2971#issuecomment-1064056063


   checkstyles are about use of numbers in test cases i want ordered, and from 
a method with 8 params. wontfix
   
   ```
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/AbstractManifestCommitterTest.java:523:
  private List<Future<Path>> createFilesOrDirs(:30: More than 7 parameters 
(found 8). [ParameterNumber]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:214:
  public void test_0000_setupTestDir() throws Throwable {:15: Name 
'test_0000_setupTestDir' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:220:
  public void test_0100_setupJobStage() throws Throwable {:15: Name 
'test_0100_setupJobStage' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:236:
  public void test_0110_setupJobOnlyAllowedOnce() throws Throwable {:15: Name 
'test_0110_setupJobOnlyAllowedOnce' must match pattern '^[a-z][a-zA-Z0-9]*$'. 
[MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:246:
  public void test_0120_setupJobNewAttemptNumber() throws Throwable {:15: Name 
'test_0120_setupJobNewAttemptNumber' must match pattern '^[a-z][a-zA-Z0-9]*$'. 
[MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:258:
  public void test_0200_setupTask00() throws Throwable {:15: Name 
'test_0200_setupTask00' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:275:
  public void test_0210_setupTask00OnlyAllowedOnce() throws Throwable {:15: 
Name 'test_0210_setupTask00OnlyAllowedOnce' must match pattern 
'^[a-z][a-zA-Z0-9]*$'. [MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:283:
  public void test_0220_setupTask01() throws Throwable {:15: Name 
'test_0220_setupTask01' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:293:
  public void test_0230_setupTask10() throws Throwable {:15: Name 
'test_0230_setupTask10' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:307:
  public void test_0240_setupThenAbortTask11() throws Throwable {:15: Name 
'test_0240_setupThenAbortTask11' must match pattern '^[a-z][a-zA-Z0-9]*$'. 
[MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:330:
  public void test_0300_executeTask00() throws Throwable {:15: Name 
'test_0300_executeTask00' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:375:
  public void test_0310_executeTask01() throws Throwable {:15: Name 
'test_0310_executeTask01' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:404:
  public void test_0320_executeTask10() throws Throwable {:15: Name 
'test_0320_executeTask10' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:418:
  public void test_0340_setupThenAbortTask11() throws Throwable {:15: Name 
'test_0340_setupThenAbortTask11' must match pattern '^[a-z][a-zA-Z0-9]*$'. 
[MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:446:
  public void test_0400_loadManifests() throws Throwable {:15: Name 
'test_0400_loadManifests' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:464:
  public void test_0410_commitJob() throws Throwable {:15: Name 
'test_0410_commitJob' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:476:
  public void test_0420_validateJob() throws Throwable {:15: Name 
'test_0420_validateJob' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:525:
  public void test_0430_validateStatistics() throws Throwable {:15: Name 
'test_0430_validateStatistics' must match pattern '^[a-z][a-zA-Z0-9]*$'. 
[MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:565:
  public void test_0900_cleanupJob() throws Throwable {:15: Name 
'test_0900_cleanupJob' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
   
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestJobThroughManifestCommitter.java:586:
  public void test_9999_cleanupTestDir() throws Throwable {:15: Name 
'test_9999_cleanupTestDir' must match pattern '^[a-z][a-zA-Z0-9]*$'. 
[MethodName]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to