tomscut commented on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1073611615
> Had a quick look, prod change makes sense to me, the `datanodeManager.getDatanode(nodeID)` methods shows it can register null, if the node isn't found. > > The test is little complex and isn't showing some actual scenario. If this issue is caused by some delay or race condition, will mocking something to create some delays and so help? > > Try to get a test which shows the actual scenario, I found it really hard to follow this test. If nothing helps, the worst would be add some comments explaining things in details in the test Thank you @ayushtkn very much for your review and detailed suggestions. I will update the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
