tomscut commented on a change in pull request #4057:
URL: https://github.com/apache/hadoop/pull/4057#discussion_r835745725



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
##########
@@ -2751,6 +2751,13 @@ public boolean checkBlockReportLease(BlockReportContext 
context,
       return true;
     }
     DatanodeDescriptor node = datanodeManager.getDatanode(nodeID);
+    if (node == null) {
+      final UnregisteredNodeException e = new 
UnregisteredNodeException(nodeID, null);
+      NameNode.stateChangeLog.error("BLOCK* NameSystem.getDatanode: " + "Data 
node " + nodeID +

Review comment:
       > @tomscut you can remove this exception from here, considering it is 
being logged in the upper method.
   > 
   > > Although it is DEBU level now, we could improve that to WARN, right?
   > 
   > I think debug is also fine, this doesn't denote any problematic stuff, 
this can happen in normal scenario as well and the datanode will register 
subsequently
   
   Hi @ayushtkn, do you mean I just remove this log?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to