brumi1024 commented on a change in pull request #4119:
URL: https://github.com/apache/hadoop/pull/4119#discussion_r839520267
##########
File path:
hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/AMRunner.java
##########
@@ -53,7 +53,7 @@
public class AMRunner {
private static final Logger LOG = LoggerFactory.getLogger(AMRunner.class);
- static int REMAINING_APPS = 0;
+ static int remainingApps = 0;
Review comment:
However if only one class is modifying this static variable a time (or
if the owner class is a singleton) there is no problem with having a static
field being modified from an instance method (a basic example would be to count
the number of instances of a class in a completely single threaded environment).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
