9uapaw commented on a change in pull request #4119:
URL: https://github.com/apache/hadoop/pull/4119#discussion_r839526303
##########
File path:
hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/AMRunner.java
##########
@@ -53,7 +53,7 @@
public class AMRunner {
private static final Logger LOG = LoggerFactory.getLogger(AMRunner.class);
- static int REMAINING_APPS = 0;
+ static int remainingApps = 0;
Review comment:
Indeed, this idiom has its places, the SpotBugs only warns us because it
is generally not a good idea. All in all, in this case, the static integer is
simply a poor architectural decision, therefore I advised in YARN-11102 to make
it an instance member, thus eliminating all kinds of errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
