[
https://issues.apache.org/jira/browse/HADOOP-18203?focusedWorklogId=758992&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-758992
]
ASF GitHub Bot logged work on HADOOP-18203:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/22 06:26
Start Date: 20/Apr/22 06:26
Worklog Time Spent: 10m
Work Description: iwasakims commented on code in PR #4174:
URL: https://github.com/apache/hadoop/pull/4174#discussion_r853767603
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:
##########
@@ -89,6 +89,21 @@ public static boolean isJava7OrAbove() {
return true;
}
+ // "1.8"->8, "9"->9, "10"->10
+ private static final int JAVA_SPEC_VER = Math.max(8, Integer.parseInt(
+ System.getProperty("java.specification.version").split("\\.")[0]));
Review Comment:
JAVA_SPEC_VER is set to 8 even on Java 7. Can we cover Java 7 here? If not,
we should have a comment for justification at least.
Issue Time Tracking
-------------------
Worklog Id: (was: 758992)
Remaining Estimate: 0h
Time Spent: 10m
> Backport HADOOP-15033 to branch-2.10
> ------------------------------------
>
> Key: HADOOP-18203
> URL: https://issues.apache.org/jira/browse/HADOOP-18203
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Reporter: Tom McCormick
> Assignee: Tom McCormick
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We need to backport this to cleanly backport HADOOP-15033
> which is needed to make this backport HADOOP-12760 work properly
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
