[
https://issues.apache.org/jira/browse/HADOOP-18203?focusedWorklogId=758993&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-758993
]
ASF GitHub Bot logged work on HADOOP-18203:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/22 06:27
Start Date: 20/Apr/22 06:27
Worklog Time Spent: 10m
Work Description: iwasakims commented on code in PR #4174:
URL: https://github.com/apache/hadoop/pull/4174#discussion_r853768370
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestShell.java:
##########
@@ -528,4 +528,9 @@ public Boolean get() {
shexc1.getProcess().waitFor();
shexc2.getProcess().waitFor();
}
+
+ @Test
+ public void testIsJavaVersionAtLeast() {
+ assertTrue(Shell.isJavaVersionAtLeast(8));
+ }
Review Comment:
This test succeeds on Java 7 since the `Shell.isJavaVersionAtLeast(8)`
returns true even on Java 7. We should have a comment for justification at
least.
Issue Time Tracking
-------------------
Worklog Id: (was: 758993)
Time Spent: 20m (was: 10m)
> Backport HADOOP-15033 to branch-2.10
> ------------------------------------
>
> Key: HADOOP-18203
> URL: https://issues.apache.org/jira/browse/HADOOP-18203
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Reporter: Tom McCormick
> Assignee: Tom McCormick
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We need to backport this to cleanly backport HADOOP-15033
> which is needed to make this backport HADOOP-12760 work properly
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
