omalley commented on code in PR #4181:
URL: https://github.com/apache/hadoop/pull/4181#discussion_r869761670
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java:
##########
@@ -133,6 +138,11 @@ public INode(String pathToNode, UserGroupInformation aUgi)
{
// and is read only.
abstract boolean isInternalDir();
+ /**
+ * INode representing a INodeDir which also contains a INodeLink(nested
mount point)
+ */
+ abstract boolean isDirAndLink();
+
// INode linking to another filesystem. Represented
// via mount table link config entries.
boolean isLink() {
Review Comment:
This feels wrong. In particular, I'd say that isLink should return true on
all links (internal & leaf). This shows as you almost always call
x.isDirAndLink() || x.isLink(). Note that the definition would need to change
from the current !isInternalDir(). Obviously isInternalDir can be used to
determine if it is an internal node versus a leaf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
