omalley commented on code in PR #4181:
URL: https://github.com/apache/hadoop/pull/4181#discussion_r870542414
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java:
##########
@@ -682,6 +748,32 @@ protected InodeTree(final Configuration config, final
String viewName,
}
}
+ /**
Review Comment:
I would argue that the simplicity of always sorting is better than the
O(mount*log(mount)) cost that happens once when the file system is created. In
fact, you at that point could move the flag into the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
