iwasakims commented on code in PR #4247: URL: https://github.com/apache/hadoop/pull/4247#discussion_r886578663
########## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml: ########## @@ -286,6 +286,13 @@ </description> </property> +<property> + <name>mapreduce.task.enable.ping-for-liveliness-check</name> + <value>true</value> Review Comment: @ashutoshcipher Making this feature disabled by default sounds right direction as @cnauroth mentioned. While no unexpected side effect was observed in the test results of current patch, there should be additional test case covering the code path of new feature enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
