ZanderXu commented on PR #4409: URL: https://github.com/apache/hadoop/pull/4409#issuecomment-1148630372
Thanks @cnauroth for your comment. Do you mean to add a UT to test that `getLifelineWaitTime()` can only return non-negative numbers? I think if we need a UT, we should test the LifelineSender thread exit, but it is difficult to judge whether the thread exits or not. Do you have some good ideas? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
