cnauroth commented on PR #4409: URL: https://github.com/apache/hadoop/pull/4409#issuecomment-1149161121
@ZanderXu , yes, I was thinking of just testing that `getLifelineWaitTime()` only returns non-negative numbers. There is a similar kind of test in `TestBpServiceActorScheduler#testScheduleLifeline`, but it doesn't yet cover the case that would lead to a negative value. I think testing for LifelineSender thread exit would be more complete, but also a lot more complex. Testing directly against the `getLifelineWaitTime()` return values is a good compromise. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
