umamaheswararao commented on code in PR #4474:
URL: https://github.com/apache/hadoop/pull/4474#discussion_r901921272
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java:
##########
@@ -215,7 +215,13 @@ private Set<String> getUnixGroups(String user) throws
IOException {
groups = resolvePartialGroupNames(user, e.getMessage(),
executor.getOutput());
} catch (PartialGroupNameException pge) {
- LOG.warn("unable to return groups for user {}", user, pge);
+ if(LOG.isDebugEnabled()) {
Review Comment:
@smengcl do you think this is fine? or we don't need this in even in Warn?
we were hitting this log message. This current patch voids the full trace in
logs when debug is not enabled.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java:
##########
@@ -215,7 +215,13 @@ private Set<String> getUnixGroups(String user) throws
IOException {
groups = resolvePartialGroupNames(user, e.getMessage(),
executor.getOutput());
} catch (PartialGroupNameException pge) {
- LOG.warn("unable to return groups for user {}", user, pge);
+ if(LOG.isDebugEnabled()) {
Review Comment:
can we just extract this into String msg = ""unable to return groups for
user {}" and use this msg to make log line looks clean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
