umamaheswararao commented on PR #4474:
URL: https://github.com/apache/hadoop/pull/4474#issuecomment-1168069961

   The -1 is due to no tests added. 
   
    -1 overall
   
   [2022-06-23T22:22:07.359Z] 
   
   [2022-06-23T22:22:07.359Z] | Vote |        Subsystem |  Runtime   | Comment
   
   [2022-06-23T22:22:07.359Z] 
============================================================================
   
   [2022-06-23T22:22:07.360Z] |   0  |          reexec  |   0m 55s   | Docker 
mode activated. 
   
   [2022-06-23T22:22:07.360Z] 
+---------------------------------------------------------------------------
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | 
Prechecks 
   
   [2022-06-23T22:22:07.360Z] 
+---------------------------------------------------------------------------
   
   [2022-06-23T22:22:07.360Z] |  +1  |         dupname  |   0m  0s   | No case 
conflicting files found. 
   
   [2022-06-23T22:22:07.360Z] |   0  |       codespell  |   0m  0s   | 
codespell was not available. 
   
   [2022-06-23T22:22:07.360Z] |   0  |      detsecrets  |   0m  0s   | 
detect-secrets was not available. 
   
   [2022-06-23T22:22:07.360Z] |  +1  |         @author  |   0m  0s   | The 
patch does not contain any @author 
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | tags.
   
   [2022-06-23T22:22:07.360Z] |  -1  |      test4tests  |   0m  0s   | The 
patch doesn't appear to include 
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | any new 
or modified tests. Please
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | justify 
why no new tests are needed for
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | this 
patch. Also please list what
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | manual 
steps were performed to verify
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | this 
patch.
   
   [2022-06-23T22:22:07.360Z] 
+---------------------------------------------------------------------------
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | trunk 
Compile Tests 
   
   [2022-06-23T22:22:07.360Z] 
+---------------------------------------------------------------------------
   
   [2022-06-23T22:22:07.360Z] |  +1  |      mvninstall  |  40m 24s   | trunk 
passed 
   
   [2022-06-23T22:22:07.360Z] |  +1  |         compile  |  25m 10s   | trunk 
passed with JDK Private 
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | 
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | 
   
   [2022-06-23T22:22:07.360Z] |  +1  |         compile  |  21m 37s   | trunk 
passed with JDK Private 
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | -b07
   
   [2022-06-23T22:22:07.360Z] |  +1  |      checkstyle  |   1m 31s   | trunk 
passed 
   
   [2022-06-23T22:22:07.360Z] |  +1  |         mvnsite  |   1m 58s   | trunk 
passed 
   
   [2022-06-23T22:22:07.360Z] |  +1  |         javadoc  |   1m 31s   | trunk 
passed with JDK Private 
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | 
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | 
   
   [2022-06-23T22:22:07.360Z] |  +1  |         javadoc  |   1m  4s   | trunk 
passed with JDK Private 
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | -b07
   
   [2022-06-23T22:22:07.360Z] |  +1  |        spotbugs  |   3m  6s   | trunk 
passed 
   
   [2022-06-23T22:22:07.360Z] |  +1  |    shadedclient  |  25m 52s   | branch 
has no errors when building and 
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | testing 
our client artifacts.
   
   [2022-06-23T22:22:07.360Z] 
+---------------------------------------------------------------------------
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | Patch 
Compile Tests 
   
   [2022-06-23T22:22:07.360Z] 
+---------------------------------------------------------------------------
   
   [2022-06-23T22:22:07.360Z] |  +1  |      mvninstall  |   1m  6s   | the 
patch passed 
   
   [2022-06-23T22:22:07.360Z] |  +1  |         compile  |  24m 13s   | the 
patch passed with JDK Private 
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | 
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | 
   
   [2022-06-23T22:22:07.360Z] |  +1  |           javac  |  24m 13s   | the 
patch passed 
   
   [2022-06-23T22:22:07.360Z] |  +1  |         compile  |  21m 45s   | the 
patch passed with JDK Private 
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | -b07
   
   [2022-06-23T22:22:07.360Z] |  +1  |           javac  |  21m 45s   | the 
patch passed 
   
   [2022-06-23T22:22:07.360Z] |  +1  |          blanks  |   0m  0s   | The 
patch has no blanks issues. 
   
   [2022-06-23T22:22:07.360Z] |  +1  |      checkstyle  |   1m 24s   | the 
patch passed 
   
   [2022-06-23T22:22:07.360Z] |  +1  |         mvnsite  |   1m 56s   | the 
patch passed 
   
   [2022-06-23T22:22:07.360Z] |  +1  |         javadoc  |   1m 22s   | the 
patch passed with JDK Private 
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | 
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | 
   
   [2022-06-23T22:22:07.360Z] |  +1  |         javadoc  |   1m  4s   | the 
patch passed with JDK Private 
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | -b07
   
   [2022-06-23T22:22:07.360Z] |  +1  |        spotbugs  |   3m  3s   | the 
patch passed 
   
   [2022-06-23T22:22:07.360Z] |  +1  |    shadedclient  |  25m 37s   | patch 
has no errors when building and 
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | testing 
our client artifacts.
   
   [2022-06-23T22:22:07.360Z] 
+---------------------------------------------------------------------------
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | Other 
Tests 
   
   [2022-06-23T22:22:07.360Z] 
+---------------------------------------------------------------------------
   
   [2022-06-23T22:22:07.360Z] |  +1  |            unit  |  18m 17s   | 
hadoop-common in the patch passed. 
   
   [2022-06-23T22:22:07.360Z] |  +1  |      asflicense  |   1m 16s   | The 
patch does not generate ASF 
   
   [2022-06-23T22:22:07.360Z] |      |                  |            | License 
warnings.
   
   [2022-06-23T22:22:07.360Z] |      |                  | 224m 51s   |
   
   Since this is only log message level change, I am approving this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to