cxzl25 commented on PR #4480:
URL: https://github.com/apache/hadoop/pull/4480#issuecomment-1164455182
> Thanks @cxzl25 for your patch. I have a question about it and looking
forward your feedback. Can this change improve the namenode performance? I see
that some places specially remove this judgment, and use log.info("{}", XXX)
replace it.
>
> Or can you do some performance test for it? use this judgment or not.
We have some JIRAs that use the `isDebugEnabled` judgment.
At the beginning, I found that the log of `Removing stale replica` has
meaningless string splicing, and using `NameNode.blockStateChangeLog` can be
replaced by `blockLog`, because this debug-level log is called a lot every day.
So I fixed the other problems by the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
