ZanderXu commented on PR #4480:
URL: https://github.com/apache/hadoop/pull/4480#issuecomment-1166793988
> But constant string concatenation is pretty simple given that String
objects are allocated from heap memory.
Yes, your are right.
```
blockLog.debug("BLOCK* invalidateBlocks: postponing " +
"invalidation of {} on {} because {} replica(s) are located on "
+
"nodes with potentially out-of-date block reports", b, dn,
nr.replicasOnStaleNodes());
```
```
if(blockLog.isDebugEnabled()) {
blockLog.debug("BLOCK* invalidateBlocks: postponing " +
"invalidation of {} on {} because {} replica(s) are located on "
+
"nodes with potentially out-of-date block reports", b, dn,
nr.replicasOnStaleNodes());
}
```
So maybe we should have a performance test that which of the above two modes
has better performance.
Do you think so? Or if you have a clear result, please let me know. Thanks
@virajjasani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
