xkrogen commented on code in PR #4511:
URL: https://github.com/apache/hadoop/pull/4511#discussion_r910430448
##########
hadoop-tools/hadoop-benchmark/pom.xml:
##########
@@ -22,11 +22,11 @@
<parent>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-project</artifactId>
- <version>3.4.0-SNAPSHOT</version>
+ <version>3.3.9-SNAPSHOT</version>
<relativePath>../../hadoop-project/pom.xml</relativePath>
</parent>
<artifactId>hadoop-benchmark</artifactId>
- <version>3.4.0-SNAPSHOT</version>
+ <version>3.3.9-SNAPSHOT</version>
Review Comment:
Just a note: this was introduced in 5c348c41ab8ddb81146355570856e61e8d129a1e
which is a backport of #3904. That PR is adding a new module,
`hadoop-benchmark`, and the version numbers weren't updated when it was
backported, so it still points to `3.4.0` (the version used by `trunk`).
I would have expected `branch-3.3` to be on `3.3.5`, but it appears from the
discussion in #4482 that `3.3.9` is expected.
##########
hadoop-project/pom.xml:
##########
@@ -1723,17 +1723,6 @@
</exclusion>
</exclusions>
</dependency>
- <dependency>
- <groupId>org.apache.hbase</groupId>
- <artifactId>hbase-server</artifactId>
- <version>${hbase.version}</version>
- <exclusions>
- <exclusion>
- <groupId>log4j</groupId>
- <artifactId>log4j</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
Review Comment:
I was unable to find any similar changes to this in
5c348c41ab8ddb81146355570856e61e8d129a1e (the backport commit of #3904) or
other related PRs that were merged:
```
> git diff 4ba463069bd apache/branch-3.3 -- hadoop-project/pom.xml | cat
diff --git a/hadoop-project/pom.xml b/hadoop-project/pom.xml
index 8dc1862ed57..39dac39eac7 100644
--- a/hadoop-project/pom.xml
+++ b/hadoop-project/pom.xml
@@ -218,6 +218,7 @@
<nodejs.version>v12.22.1</nodejs.version>
<yarnpkg.version>v1.22.5</yarnpkg.version>
<apache-ant.version>1.10.11</apache-ant.version>
+ <jmh.version>1.20</jmh.version>
</properties>
<dependencyManagement>
@@ -1603,6 +1604,16 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.openjdk.jmh</groupId>
+ <artifactId>jmh-core</artifactId>
+ <version>${jmh.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.openjdk.jmh</groupId>
+ <artifactId>jmh-generator-annprocess</artifactId>
+ <version>${jmh.version}</version>
+ </dependency>
<dependency>
<groupId>org.apache.curator</groupId>
<artifactId>curator-test</artifactId>
```
Why is this change necessary / how is it related to the backport?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
