[ 
https://issues.apache.org/jira/browse/HADOOP-18315?focusedWorklogId=786205&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-786205
 ]

ASF GitHub Bot logged work on HADOOP-18315:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jun/22 21:35
            Start Date: 29/Jun/22 21:35
    Worklog Time Spent: 10m 
      Work Description: xkrogen commented on code in PR #4511:
URL: https://github.com/apache/hadoop/pull/4511#discussion_r910430448


##########
hadoop-tools/hadoop-benchmark/pom.xml:
##########
@@ -22,11 +22,11 @@
   <parent>
     <groupId>org.apache.hadoop</groupId>
     <artifactId>hadoop-project</artifactId>
-    <version>3.4.0-SNAPSHOT</version>
+    <version>3.3.9-SNAPSHOT</version>
     <relativePath>../../hadoop-project/pom.xml</relativePath>
   </parent>
   <artifactId>hadoop-benchmark</artifactId>
-  <version>3.4.0-SNAPSHOT</version>
+  <version>3.3.9-SNAPSHOT</version>

Review Comment:
   Just a note: this was introduced in 5c348c41ab8ddb81146355570856e61e8d129a1e 
which is a backport of #3904. That PR is adding a new module, 
`hadoop-benchmark`, and the version numbers weren't updated when it was 
backported, so it still points to `3.4.0` (the version used by `trunk`).
   
   I would have expected `branch-3.3` to be on `3.3.5`, but it appears from the 
discussion in #4482 that `3.3.9` is expected.



##########
hadoop-project/pom.xml:
##########
@@ -1723,17 +1723,6 @@
           </exclusion>
         </exclusions>
       </dependency>
-      <dependency>
-        <groupId>org.apache.hbase</groupId>
-        <artifactId>hbase-server</artifactId>
-        <version>${hbase.version}</version>
-        <exclusions>
-          <exclusion>
-            <groupId>log4j</groupId>
-            <artifactId>log4j</artifactId>
-          </exclusion>
-        </exclusions>
-      </dependency>

Review Comment:
   I was unable to find any similar changes to this in 
5c348c41ab8ddb81146355570856e61e8d129a1e (the backport commit of #3904) or 
other related PRs that were merged:
   ```
   > git diff 4ba463069bd apache/branch-3.3  

Issue Time Tracking
-------------------

    Worklog Id:     (was: 786205)
    Time Spent: 20m  (was: 10m)

> Fix 3.3 build problems caused by backport of HADOOP-11867.
> ----------------------------------------------------------
>
>                 Key: HADOOP-18315
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18315
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.3.5
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to