goiri commented on code in PR #4529:
URL: https://github.com/apache/hadoop/pull/4529#discussion_r916458093
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java:
##########
@@ -478,10 +478,7 @@ public void recoverUnfinalizedSegments() throws
IOException {
Map<AsyncLogger, NewEpochResponseProto> resps = createNewUniqueEpoch();
LOG.info("Successfully started new epoch " + loggers.getEpoch());
- if (LOG.isDebugEnabled()) {
- LOG.debug("newEpoch(" + loggers.getEpoch() + ") responses:\n" +
- QuorumCall.mapToString(resps));
- }
+ LOG.debug("newEpoch({}) responses:\n{}", loggers.getEpoch(),
QuorumCall.mapToString(resps));
Review Comment:
This particular one should stay within the isDebugEnabled() to avoid the
mapToString
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java:
##########
@@ -618,10 +612,8 @@ private void selectStreamingInputStreams(
Map<AsyncLogger, RemoteEditLogManifest> resps =
loggers.waitForWriteQuorum(q, selectInputStreamsTimeoutMs,
"selectStreamingInputStreams");
- if (LOG.isDebugEnabled()) {
- LOG.debug("selectStreamingInputStream manifests:\n {}",
- Joiner.on("\n").withKeyValueSeparator(": ").join(resps));
- }
+ LOG.debug("selectStreamingInputStream manifests:\n {}",
Review Comment:
This probably should stay.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##########
@@ -2908,11 +2896,9 @@ public boolean processReport(final DatanodeID nodeID,
if (blockLog.isDebugEnabled()) {
for (Block b : invalidatedBlocks) {
- if (blockLog.isDebugEnabled()) {
- blockLog.debug("BLOCK* processReport 0x{} with lease ID 0x{}: {} on
node {} size {} " +
- "does not belong to any file.", strBlockReportId,
fullBrLeaseId, b,
- node, b.getNumBytes());
- }
+ blockLog.debug("BLOCK* processReport 0x{} with lease ID 0x{}: {} on
node {} size {} " +
Review Comment:
Don't we want to keep the check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
