[GitHub] [hadoop] goiri commented on a diff in pull request #4530: HDFS-15079. RBF: Namenode needs to use the actual client Id and callId when going through RBF proxy.

[GitBox]

goiri commented on code in PR #4530:
URL: https://github.com/apache/hadoop/pull/4530#discussion_r920337146


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java:
##########
@@ -140,7 +140,7 @@ public long getExpirationTime() {
     
     @Override
     public String toString() {
-      return (new UUID(this.clientIdMsb, this.clientIdLsb)).toString() + ":"
+      return (new UUID(this.clientIdMsb, this.clientIdLsb)) + ":"

Review Comment:
   Maybe is cleaner to have this as String.format()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org