ZanderXu commented on code in PR #4530:
URL: https://github.com/apache/hadoop/pull/4530#discussion_r922997833
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##########
@@ -495,6 +498,94 @@ public static NameNodeMetrics getNameNodeMetrics() {
return metrics;
}
+ /**
+ * Try to obtain the actual client info according to the current user.
+ * @param ipProxyUsers Users who can override client infos
+ */
+ private static String clientInfoFromContext(
+ final String[] ipProxyUsers) {
+ if (ipProxyUsers != null) {
+ UserGroupInformation user =
+ UserGroupInformation.getRealUserOrSelf(Server.getRemoteUser());
+ if (user != null &&
+ ArrayUtils.contains(ipProxyUsers, user.getShortUserName())) {
+ CallerContext context = CallerContext.getCurrent();
+ if (context != null && context.isContextValid()) {
+ return context.getContext();
+ }
+ }
+ }
+ return null;
+ }
+
+ /**
+ * Try to obtain the value corresponding to the key by parsing the content.
+ * @param content the full content to be parsed.
+ * @param key trying to obtain the value of the key.
+ * @return the value corresponding to the key.
+ */
+ @VisibleForTesting
+ public static String parseSpecialValue(String content, String key) {
+ int posn = content.indexOf(key);
+ if (posn != -1) {
+ posn += key.length();
+ int end = content.indexOf(",", posn);
+ return end == -1 ? content.substring(posn)
+ : content.substring(posn, end);
+ }
+ return null;
+ }
+
+ /**
+ * Try to obtain the actual client's machine according to the current user.
+ * @param ipProxyUsers Users who can override client infos.
+ * @return The actual client's machine.
+ */
+ public static String getClientMachine(final String[] ipProxyUsers) {
Review Comment:
Thanks @ferhui for your review.
`NameNodeRpcServer#getClientMachine()` will use this method as follows:
```
/**
* Get the actual client's machine.
*/
private String getClientMachine() {
return NameNode.getClientMachine(this.ipProxyUsers);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
