goiri commented on code in PR #4540:
URL: https://github.com/apache/hadoop/pull/4540#discussion_r922725216
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/util/resource/ResourceUtils.java:
##########
@@ -917,4 +919,17 @@ private static void validateResourceTypes(
}
return res;
}
+
+ public static Resource mergeResources(Resource r1, Resource r2) {
Review Comment:
I was referring to Resources.add():
https://github.com/apache/hadoop/blob/8774f178686487007dcf8c418c989b785a529000/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/resource/Resources.java#L250
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/util/resource/ResourceUtils.java:
##########
@@ -115,8 +115,8 @@ private static void checkSpecialResources(
* Supporting 'memory', 'memory-mb', 'vcores' also as invalid resource
* names, in addition to 'MEMORY' for historical reasons
*/
- String[] keys = { "memory", ResourceInformation.MEMORY_URI,
- ResourceInformation.VCORES_URI };
+ String[] keys = {"memory", ResourceInformation.MEMORY_URI,
Review Comment:
As we are at it... let's make it a single line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
