slfan1989 commented on code in PR #4540:
URL: https://github.com/apache/hadoop/pull/4540#discussion_r922908676
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##########
@@ -1448,13 +1448,52 @@ public UpdateApplicationTimeoutsResponse
updateApplicationTimeouts(
@Override
public GetAllResourceProfilesResponse getResourceProfiles(
GetAllResourceProfilesRequest request) throws YarnException, IOException
{
- throw new NotImplementedException("Code is not implemented");
+ if (request == null) {
+ routerMetrics.incrGetResourceProfilesFailedRetrieved();
+ RouterServerUtil.logAndThrowException("Missing getResourceProfiles
request.", null);
+ }
+ long startTime = clock.getTime();
+ ClientMethod remoteMethod = new ClientMethod("getResourceProfiles",
+ new Class[] {GetAllResourceProfilesRequest.class}, new Object[]
{request});
+ Collection<GetAllResourceProfilesResponse> resourceProfiles;
+ try {
+ resourceProfiles = invokeAppClientProtocolMethod(true, remoteMethod,
+ GetAllResourceProfilesResponse.class);
+ } catch (Exception ex) {
+ routerMetrics.incrGetResourceProfilesFailedRetrieved();
+ LOG.error("Unable to get resource profiles due to exception.", ex);
+ throw ex;
+ }
+ long stopTime = clock.getTime();
+ routerMetrics.succeededGetResourceProfilesRetrieved(stopTime - startTime);
+ // Merge the GetAllResourceProfilesResponse
Review Comment:
I will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
