[
https://issues.apache.org/jira/browse/HADOOP-18345?focusedWorklogId=795096&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795096
]
ASF GitHub Bot logged work on HADOOP-18345:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/22 02:15
Start Date: 26/Jul/22 02:15
Worklog Time Spent: 10m
Work Description: simbadzina commented on PR #4584:
URL: https://github.com/apache/hadoop/pull/4584#issuecomment-1194894453
Yes, it should be optional. Thanks for spotting the error. I'll fix that.
I'm considering making the field a byte array in the client protocol. Only
routers need to parse it.
On Mon, Jul 25, 2022, 16:51 Erik Krogen ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto
> <https://github.com/apache/hadoop/pull/4584#discussion_r929398786>:
>
> > @@ -157,6 +158,7 @@ message RpcResponseHeaderProto {
> optional bytes clientId = 7; // Globally unique client ID
> optional sint32 retryCount = 8 [default = -1];
> optional int64 stateId = 9; // The last written Global State ID
> + map<string, int64> nameserviceStateIds = 10; // Last seen state IDs for
multiple nameservices.
>
> Doesn't this field need to be optional for backwards compatibility?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/hadoop/pull/4584#discussion_r929398786>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AC6NI6DC23A4WNI4AARIIW3VV4SBNANCNFSM53457PHA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
Issue Time Tracking
-------------------
Worklog Id: (was: 795096)
Time Spent: 1h 40m (was: 1.5h)
> Enhance client protocol to propagate last seen state IDs for multiple
> nameservices.
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-18345
> URL: https://issues.apache.org/jira/browse/HADOOP-18345
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Simbarashe Dzinamarira
> Assignee: Simbarashe Dzinamarira
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The RPCHeader in the client protocol currently contains a single value to
> indicate the last seen state ID for a namenode.
> {noformat}
> optional int64 stateId = 8; // The last seen Global State ID
> {noformat}
> When there are multiple namenodes, such as in router based federation, the
> headers need to carry the state IDs for each of these nameservices that are
> part of the federation.
> This change is a prerequisite for HDFS-13522: RBF: Support observer node from
> Router-Based Federation
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
