[
https://issues.apache.org/jira/browse/HADOOP-18345?focusedWorklogId=795794&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795794
]
ASF GitHub Bot logged work on HADOOP-18345:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/22 18:43
Start Date: 27/Jul/22 18:43
Worklog Time Spent: 10m
Work Description: simbadzina commented on code in PR #4584:
URL: https://github.com/apache/hadoop/pull/4584#discussion_r931470957
##########
hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto:
##########
@@ -157,6 +158,7 @@ message RpcResponseHeaderProto {
optional bytes clientId = 7; // Globally unique client ID
optional sint32 retryCount = 8 [default = -1];
optional int64 stateId = 9; // The last written Global State ID
+ map<string, int64> nameserviceStateIds = 10; // Last seen state IDs for
multiple nameservices.
Review Comment:
Yes, it should be optional. Thanks for spotting the error. I'll fix that.
I'm also going to make this a bytearray since the client doesn't need to
parse it. This will give us the flexibility to evolve the contents in the
routers.
Issue Time Tracking
-------------------
Worklog Id: (was: 795794)
Time Spent: 1h 50m (was: 1h 40m)
> Enhance client protocol to propagate last seen state IDs for multiple
> nameservices.
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-18345
> URL: https://issues.apache.org/jira/browse/HADOOP-18345
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Simbarashe Dzinamarira
> Assignee: Simbarashe Dzinamarira
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The RPCHeader in the client protocol currently contains a single value to
> indicate the last seen state ID for a namenode.
> {noformat}
> optional int64 stateId = 8; // The last seen Global State ID
> {noformat}
> When there are multiple namenodes, such as in router based federation, the
> headers need to carry the state IDs for each of these nameservices that are
> part of the federation.
> This change is a prerequisite for HDFS-13522: RBF: Support observer node from
> Router-Based Federation
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
