GauthamBanasandra commented on code in PR #4616:
URL: https://github.com/apache/hadoop/pull/4616#discussion_r930987990
##########
hadoop-common-project/hadoop-common/src/main/native/native.vcxproj:
##########
@@ -39,12 +37,14 @@
<UseDebugLibraries>false</UseDebugLibraries>
<WholeProgramOptimization>true</WholeProgramOptimization>
<CharacterSet>Unicode</CharacterSet>
+ <PlatformToolset>v142</PlatformToolset>
Review Comment:
> why would we add it now?
The compilation fails without the `PlatformToolset` when compiled with
Visual Studio 2019 (I'm not sure about VS2010). I'm fine with documenting
running the retarget command as a pre-requisite step prior to running the `mvn
install` command, if we don't want to add the `PlatformToolset` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
