GauthamBanasandra commented on code in PR #4616:
URL: https://github.com/apache/hadoop/pull/4616#discussion_r932136279
##########
hadoop-common-project/hadoop-common/src/main/native/native.vcxproj:
##########
@@ -39,12 +37,14 @@
<UseDebugLibraries>false</UseDebugLibraries>
<WholeProgramOptimization>true</WholeProgramOptimization>
<CharacterSet>Unicode</CharacterSet>
+ <PlatformToolset>v142</PlatformToolset>
Review Comment:
This is amazing. Thanks for sharing this @goiri 😊. I'm able to confirm that
while building the `hadoop-common-project` module, the vcxproj and solution
files automatically get upgraded to the appropriate Visual Studio version. All
thanks to
https://github.com/apache/hadoop/blob/95a85875d0038a73f7e6c2cdb6efdc5132d63beb/hadoop-common-project/hadoop-common/pom.xml#L844-L923
```
[INFO] --- exec-maven-plugin:1.3.1:exec (convert-ms-native-dll) @
hadoop-common ---
C:\Program Files (x86)\Microsoft Visual
Studio\2019\Enterprise\Common7\IDE\devenv.com
C:\Program Files (x86)\Microsoft Visual
Studio\2019\Enterprise\Common7\IDE\devenv.exe
Microsoft Visual Studio 2019 Version 16.11.9.
Copyright (C) Microsoft Corp. All rights reserved.
Upgrading project 'native'...
Configuration 'Release|Win32': changing Platform Toolset to 'v142'
(was 'v100').
Configuration 'Release|x64': changing Platform Toolset to 'v142'
(was 'v100').
Migration completed successfully, but some warnings were detected during
migration.
For more information, see the migration report:
E:\hadoop-common-project\hadoop-common\src\main\native\UpgradeLog.htm
```
I'm able to fully build the trunk as well -
I'll abandon this PR since I'm able to build the trunk on Windows without
these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
