slfan1989 commented on code in PR #4650:
URL: https://github.com/apache/hadoop/pull/4650#discussion_r933076163
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:
##########
@@ -867,19 +878,20 @@ public static class RequestInterceptorChainWrapper {
/**
* Initializes the wrapper with the specified parameters.
*
- * @param rootInterceptor the root request intercepter
+ * @param rootInterceptor the root request interceptor
* @param applicationAttemptId attempt id
*/
+ @SuppressWarnings("checkstyle:HiddenField")
Review Comment:
I read the code and I think there is no problem with the variable naming and
methods, the problem is on the HiddenField check in checkstyle, I added a xml
configuration that doesn't check for variables that contain init characters.
```
<module name="HiddenField">
-- add configuration
<property name="ignoreFormat" value="init"/>
<property name="ignoreConstructorParameter" value="true"/>
<property name="ignoreSetter" value="true"/>
</module>
```
Is it possible for me to do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
