goiri commented on code in PR #4650:
URL: https://github.com/apache/hadoop/pull/4650#discussion_r933376779
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:
##########
@@ -182,27 +187,23 @@ protected void serviceStart() throws Exception {
listenerEndpoint, serverConf, this.secretManager,
numWorkerThreads);
- if (conf
-
.getBoolean(CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTHORIZATION,
- false)) {
- this.server.refreshServiceAcl(conf, NMPolicyProvider.getInstance());
+ if
(conf.getBoolean(CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTHORIZATION,
false)) {
+ this.server.refreshServiceAcl(conf, NMPolicyProvider.getInstance());
}
this.server.start();
- LOG.info("AMRMProxyService listening on address: "
- + this.server.getListenerAddress());
+ LOG.info("AMRMProxyService listening on address: {}.",
this.server.getListenerAddress());
super.serviceStart();
}
@Override
protected void serviceStop() throws Exception {
- LOG.info("Stopping AMRMProxyService");
+ LOG.info("Stopping AMRMProxyService, askCount = {}, allocatedCount = {}.",
Review Comment:
`requestCount`
Not clear why we would log this here though.
##########
hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml:
##########
@@ -174,6 +174,7 @@
<module name="EmptyStatement"/>
<module name="EqualsHashCode"/>
<module name="HiddenField">
+ <property name="ignoreFormat" value="init"/>
Review Comment:
Let's not do this.
It has lots of side effects.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyMetrics.java:
##########
@@ -44,7 +44,12 @@ public final class AMRMProxyMetrics {
@Metric("# of failed allocate requests ")
private MutableGaugeLong failedAllocateRequests;
@Metric("# of failed application recoveries")
- private MutableGaugeLong failedAppRecoveryCount;
Review Comment:
I think we need to keep backwards compatibility; we cannot just remove an
existing metric.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:
##########
@@ -292,26 +298,29 @@ public void recover() throws IOException {
/**
* This is called by the AMs started on this node to register with the RM.
* This method does the initial authorization and then forwards the request
to
- * the application instance specific intercepter chain.
+ * the application instance specific interceptor chain.
*/
@Override
public RegisterApplicationMasterResponse registerApplicationMaster(
RegisterApplicationMasterRequest request) throws YarnException,
IOException {
+ this.requestCount.incrementAndGet();
long startTime = clock.getTime();
try {
RequestInterceptorChainWrapper pipeline =
authorizeAndGetInterceptorChain();
- LOG.info("Registering application master." + " Host:" + request.getHost()
- + " Port:" + request.getRpcPort() + " Tracking Url:" + request
- .getTrackingUrl() + " for application " + pipeline
- .getApplicationAttemptId());
+
+ LOG.info("Registering application master. " +
Review Comment:
Does the string fit in one line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
