slfan1989 commented on code in PR #4650:
URL: https://github.com/apache/hadoop/pull/4650#discussion_r933916206
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:
##########
@@ -182,27 +187,23 @@ protected void serviceStart() throws Exception {
listenerEndpoint, serverConf, this.secretManager,
numWorkerThreads);
- if (conf
-
.getBoolean(CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTHORIZATION,
- false)) {
- this.server.refreshServiceAcl(conf, NMPolicyProvider.getInstance());
+ if
(conf.getBoolean(CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTHORIZATION,
false)) {
+ this.server.refreshServiceAcl(conf, NMPolicyProvider.getInstance());
}
this.server.start();
- LOG.info("AMRMProxyService listening on address: "
- + this.server.getListenerAddress());
+ LOG.info("AMRMProxyService listening on address: {}.",
this.server.getListenerAddress());
super.serviceStart();
}
@Override
protected void serviceStop() throws Exception {
- LOG.info("Stopping AMRMProxyService");
+ LOG.info("Stopping AMRMProxyService, requestCount = {}, allocatedCount =
{}.",
Review Comment:
I agree with your suggestion, I will modify the title of jira and convert
requestCount to metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
