goiri commented on code in PR #4650:
URL: https://github.com/apache/hadoop/pull/4650#discussion_r933858260
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:
##########
@@ -182,27 +187,23 @@ protected void serviceStart() throws Exception {
listenerEndpoint, serverConf, this.secretManager,
numWorkerThreads);
- if (conf
-
.getBoolean(CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTHORIZATION,
- false)) {
- this.server.refreshServiceAcl(conf, NMPolicyProvider.getInstance());
+ if
(conf.getBoolean(CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTHORIZATION,
false)) {
+ this.server.refreshServiceAcl(conf, NMPolicyProvider.getInstance());
}
this.server.start();
- LOG.info("AMRMProxyService listening on address: "
- + this.server.getListenerAddress());
+ LOG.info("AMRMProxyService listening on address: {}.",
this.server.getListenerAddress());
super.serviceStart();
}
@Override
protected void serviceStop() throws Exception {
- LOG.info("Stopping AMRMProxyService");
+ LOG.info("Stopping AMRMProxyService, requestCount = {}, allocatedCount =
{}.",
Review Comment:
Wait, I just realized this is the whole point of this PR.
Do we really need to do all this to log in the stopping?
Shouldn't this be exposed as a metric and that's it?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:
##########
@@ -182,27 +187,23 @@ protected void serviceStart() throws Exception {
listenerEndpoint, serverConf, this.secretManager,
numWorkerThreads);
- if (conf
-
.getBoolean(CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTHORIZATION,
- false)) {
- this.server.refreshServiceAcl(conf, NMPolicyProvider.getInstance());
+ if
(conf.getBoolean(CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTHORIZATION,
false)) {
+ this.server.refreshServiceAcl(conf, NMPolicyProvider.getInstance());
}
this.server.start();
- LOG.info("AMRMProxyService listening on address: "
- + this.server.getListenerAddress());
+ LOG.info("AMRMProxyService listening on address: {}.",
this.server.getListenerAddress());
super.serviceStart();
}
@Override
protected void serviceStop() throws Exception {
- LOG.info("Stopping AMRMProxyService");
+ LOG.info("Stopping AMRMProxyService, requestCount = {}, allocatedCount =
{}.",
Review Comment:
I don't think we should log this details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
