goiri commented on code in PR #4746:
URL: https://github.com/apache/hadoop/pull/4746#discussion_r948373053
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/utils/TestFederationStateStoreFacade.java:
##########
@@ -312,10 +312,10 @@ public void testUpdateNewToken() throws YarnException,
IOException {
facade.updateStoredToken(dtId1, renewDate1);
token1.put(dtId1, renewDate1);
- MemoryFederationStateStore stateStore =
+ MemoryFederationStateStore federationStateStore =
Review Comment:
Why changing the name? It is pretty clear in this context.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/security/RouterDelegationTokenSecretManager.java:
##########
@@ -63,8 +63,9 @@
* in milliseconds
* @param delegationTokenRemoverScanInterval how often the tokens are scanned
*/
- public RouterDelegationTokenSecretManager(long delegationKeyUpdateInterval,
long delegationTokenMaxLifetime,
- long delegationTokenRenewInterval, long
delegationTokenRemoverScanInterval) {
+ public RouterDelegationTokenSecretManager(long delegationKeyUpdateInterval,
Review Comment:
Do we need to do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
