slfan1989 commented on code in PR #4746:
URL: https://github.com/apache/hadoop/pull/4746#discussion_r949061631


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/security/RouterDelegationTokenSecretManager.java:
##########
@@ -63,8 +63,9 @@
    *                                           in milliseconds
    * @param delegationTokenRemoverScanInterval how often the tokens are scanned
    */
-  public RouterDelegationTokenSecretManager(long delegationKeyUpdateInterval, 
long delegationTokenMaxLifetime,
-      long delegationTokenRenewInterval, long 
delegationTokenRemoverScanInterval) {
+  public RouterDelegationTokenSecretManager(long delegationKeyUpdateInterval,

Review Comment:
   RouterDelegationTokenSecretManager.java is a new file, the length of the 
constructor parameter exceeds 100 characters.
   
   ```
   RouterDelegationTokenSecretManager.java:66:  public 
RouterDelegationTokenSecretManager(long 
   delegationKeyUpdateInterval, long delegationTokenMaxLifetime,: Line is 
longer than 100 characters (found 110). 
   [LineLength]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to