K0K0V0K commented on code in PR #4941:
URL: https://github.com/apache/hadoop/pull/4941#discussion_r989833801
##########
hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/SLSCapacityScheduler.java:
##########
@@ -105,7 +108,11 @@ public boolean tryCommit(Resource cluster,
ResourceCommitRequest r,
@Override
public void handle(SchedulerEvent schedulerEvent) {
- schedulerCommons.handle(schedulerEvent);
+ try{
+ schedulerCommons.handle(schedulerEvent);
Review Comment:
This catch can be problematic, cause there is a chance that some logic what
used this code expected an exception in case of the SLSCapacityScheduler can
not handle the event, what exception now wont be provided for the caller.
Please can you check how this method is used by the rest of the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
