K0K0V0K commented on code in PR #4941:
URL: https://github.com/apache/hadoop/pull/4941#discussion_r993049710
##########
hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RMRunner.java:
##########
@@ -107,7 +111,11 @@ public void increaseQueueAppNum(String queue) throws
YarnException {
queueAppNumMap.put(queueName, appNum);
SchedulerMetrics metrics = wrapper.getSchedulerMetrics();
if (metrics != null) {
- metrics.trackQueue(queueName);
+ try {
+ metrics.trackQueue(queueName);
+ } catch (Exception e) {
+ LOG.error("Caught exception while tracking a queue", e);
Review Comment:
can you please check if we wont throw the error from here, that wont cause
any issue
##########
hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/SchedulerMetrics.java:
##########
@@ -160,8 +160,13 @@ void init(ResourceScheduler resourceScheduler,
Configuration config)
registerClusterResourceMetrics();
registerContainerAppNumMetrics();
registerSchedulerMetrics();
- registerNodesUsageMetrics("memory");
- registerNodesUsageMetrics("vcores");
+
+ try{
+ registerNodesUsageMetrics("memory");
+ registerNodesUsageMetrics("vcores");
+ } catch(Exception e){
+ LOG.error("Caught exception while registering scheduler metrics", e);
Review Comment:
Is it ok if we wont throw an exception here, and the program continue ?
##########
hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/SLSFairScheduler.java:
##########
@@ -40,6 +42,7 @@ public class SLSFairScheduler extends FairScheduler
implements SchedulerWrapper, Configurable {
private final SLSSchedulerCommons schedulerCommons;
private SLSRunner runner;
+ private static final Logger LOG =
LoggerFactory.getLogger(SLSSchedulerCommons.class);
Review Comment:
This logger is linked to a wrong class
##########
hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/RMRunner.java:
##########
@@ -45,6 +48,7 @@ public class RMRunner {
private SLSRunner slsRunner;
private String tableMapping;
private Map<String, Integer> queueAppNumMap;
+ private static final Logger LOG =
LoggerFactory.getLogger(SLSSchedulerCommons.class);
Review Comment:
This logger is linked to a wrong class
##########
hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/SLSCapacityScheduler.java:
##########
@@ -45,6 +47,7 @@ public class SLSCapacityScheduler extends CapacityScheduler
implements
private final SLSSchedulerCommons schedulerCommons;
private Configuration conf;
private SLSRunner runner;
+ private static final Logger LOG =
LoggerFactory.getLogger(SLSSchedulerCommons.class);
Review Comment:
This logger is linked to a wrong class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
