[
https://issues.apache.org/jira/browse/HADOOP-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204708#comment-13204708
]
Thomas Graves commented on HADOOP-8048:
---------------------------------------
overall looks good. A couple minor nits.
- it would be nice to have another token and service already in creds object
and verify that they aren't changed/removed during the addAll/mergeAll.
- very minor - in the test for mergeAll I think your comments about check for
new/existing don't match up with the asserts exactly. its checks 2 tokens, then
2 services and it should be 1 token/1 service and then 1 token/1service. see
addAll for the right order.
> Allow merging of Credentials
> ----------------------------
>
> Key: HADOOP-8048
> URL: https://issues.apache.org/jira/browse/HADOOP-8048
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-8048.patch
>
>
> There is an existing {{Credentials#addAll}} which combines two
> {{Credentials}}, but it overwrites all existing {{Credentials}}. There
> should be a {{Credentials#mergeAll}} that will not overwrite. This will
> facility the cleanup of code in {{TokenCache}} denoted with:
> {code}
> //TODO: Need to come up with a better place to put
> //this block of code to do with reading the file
> {code}
> The token cache basically needs to merge the contents of a binary credentials
> file when it fails to find a token. Performing the merge within
> {{Credentials}} is cleaner, and will break the cross-component dependency
> whereby the {{TokenCache}} currently has to have intimate knowledge of how
> the {{FileSystem}} will key tokens in the cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
