[
https://issues.apache.org/jira/browse/HADOOP-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204977#comment-13204977
]
Hadoop QA commented on HADOOP-8048:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12514021/HADOOP-8048-2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/583//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/583//console
This message is automatically generated.
> Allow merging of Credentials
> ----------------------------
>
> Key: HADOOP-8048
> URL: https://issues.apache.org/jira/browse/HADOOP-8048
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-8048-2.patch, HADOOP-8048.patch
>
>
> There is an existing {{Credentials#addAll}} which combines two
> {{Credentials}}, but it overwrites all existing {{Credentials}}. There
> should be a {{Credentials#mergeAll}} that will not overwrite. This will
> facility the cleanup of code in {{TokenCache}} denoted with:
> {code}
> //TODO: Need to come up with a better place to put
> //this block of code to do with reading the file
> {code}
> The token cache basically needs to merge the contents of a binary credentials
> file when it fails to find a token. Performing the merge within
> {{Credentials}} is cleaner, and will break the cross-component dependency
> whereby the {{TokenCache}} currently has to have intimate knowledge of how
> the {{FileSystem}} will key tokens in the cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
