[
https://issues.apache.org/jira/browse/HADOOP-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615696#comment-17615696
]
ASF GitHub Bot commented on HADOOP-18476:
-----------------------------------------
rbalamohan commented on code in PR #4966:
URL: https://github.com/apache/hadoop/pull/4966#discussion_r992186965
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3A.java:
##########
@@ -54,4 +55,13 @@ public String toString() {
sb.append('}');
return sb.toString();
}
+
+ /**
+ * Close the file system; the FileContext API doesn't have an explicit close.
+ */
+ @Override
+ protected void finalize() throws Throwable {
Review Comment:
Agreed. May have to change finalize() when JDK version support is upgraded
in hadoop.
w.r.t GC causes, it may not look at thread count as a reason for triggering
GC.
https://github.com/AdoptOpenJDK/openjdk-jdk8u/blob/master/hotspot/src/share/vm/gc_interface/gcCause.hpp#L39
https://github.com/AdoptOpenJDK/openjdk-jdk8u/blob/master/hotspot/src/share/vm/gc_interface/gcCause.cpp#L28
> Abfs and S3A FileContext bindings to close wrapped filesystems in finalizer
> ---------------------------------------------------------------------------
>
> Key: HADOOP-18476
> URL: https://issues.apache.org/jira/browse/HADOOP-18476
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure, fs/s3
> Affects Versions: 3.3.4
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Blocker
> Labels: pull-request-available
>
> if you use the FileContext APIs to talk to abfs or s3a, it creates a new
> wrapped FileSystem implementation, and, because there is no close() call,
> never cleans up.
> proposed: add finalizers for these two classes, which we know create helper
> threads, especially if plugins are added
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
