[ 
https://issues.apache.org/jira/browse/HADOOP-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619746#comment-17619746
 ] 

ASF GitHub Bot commented on HADOOP-18476:
-----------------------------------------

mukund-thakur commented on PR #4966:
URL: https://github.com/apache/hadoop/pull/4966#issuecomment-1282879920

   > you know, the other thing to think of here is have finalize() methods in 
s3a/abfs, though they aren't ever encouraged
   
   You mean in the S3AFileSystem and ABFS right? Yes, I guess we can add but 
then there are close() methods already there. 




> Abfs and S3A FileContext bindings to close wrapped filesystems in finalizer
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-18476
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18476
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure, fs/s3
>    Affects Versions: 3.3.4
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 3.3.5, 3.3.9
>
>
> if you use the FileContext APIs to talk to abfs or s3a, it creates a new 
> wrapped FileSystem implementation, and, because there is no close() call, 
> never cleans up.
> proposed: add finalizers for these two classes, which we know create helper 
> threads, especially if plugins are added



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to